Shell-quote values interpolated into Buildkite pipeline commands - #2824
Merged
Merged
Conversation
h1-mrz
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
August 26, 2026 13:04
Contributor
Author
|
Hi @Wyverald @fweikert @meteorcloudy, |
meteorcloudy
enabled auto-merge (squash)
September 9, 2026 13:56
Follow-up to bazelbuild#2666: apply shlex.quote consistently to the remaining pipeline-command builders so every value interpolated into a project_pipeline command line is quoted the same way: - create_config_validation_steps: quote --file_config (the config file name comes from the PR's modified files) - upload_project_pipeline_step: quote project_name, git_repository, http_config, file_config and git_commit instead of manual double quotes / raw interpolation Updates the corresponding test expectation to the shlex.quote style.
meteorcloudy
force-pushed
the
fix-bazelci-pipeline-quote
branch
from
September 9, 2026 14:15
5490167 to
d246f9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2666: apply
shlex.quoteconsistently to the remaining pipeline-command builders so every value interpolated into aproject_pipelinecommand line is quoted the same way.create_config_validation_steps: quote--file_config(the config file name comes from the PR's modified files)upload_project_pipeline_step: quoteproject_name,git_repository,http_config,file_configandgit_commitinstead of manual double quotes / raw interpolationUpdates the corresponding test expectation to the
shlex.quotestyle.